[RFC] Replace viminfo with ShaDa files#2506
Merged
Merged
Conversation
938455a to
a3fd0ac
Compare
Member
There was a problem hiding this comment.
102 400 is very unusual in U.S. 100 KiB would be better.
6d635a1 to
e2c374b
Compare
1824689 to
657ca52
Compare
3e385c3 to
48a4399
Compare
02e11d1 to
271b1c2
Compare
It was the behaviour exhibited by Vim, but it got unintentionally removed. There is a difference though: Vim runs fchown *before* populating the file, I run it just before renaming.
It is not logical that on UNIX permissions can prevent even writing temporary file, while on other OS it will first write temporary file and then fail during rename.
It leads to a memory leak as well. May overwrite wms->jumps_size.
Problem that led to this skip was fixed in [neovim#3309][1]. [1]: neovim@0a116c8
Errors happens under following conditions: 1. Jump/change list is full. 2. New jump/change list item should go between some of the old ones.
- Remove unused variables. - Do not use helpers.nvim_feed in most cases. - Do not use helpers.nvim and helpers.nvim_eval at all. - Add helpers.funcs and helpers.\*meths special tables. Indexing such table creates functions which call helpers.call or helpers.nvim (and similar) with first argument equal to table index.
Should protect against neovim#3431
Contributor
Author
|
They currently cost only one redirect in help file, which will hopefully cause user to review his settings. By the time deprecated option and commands are removed I expect ShaDa files be more useful then currently: specifically this format was designed also to make it possible to have zsh-style history sharing options somewhere in the future which were mentioned in #999. |
Member
Contributor
|
👍 Congrats, everyone! |
Member
|
👍 great work |
Contributor
|
Awesome job guys!! |
|
👍 great job! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains replacement for the viminfo file discussed in #999.
sitem size limit.sitem size limit being used when merging for “foreign” items..tmp.bwhen.tmp.aalready exists..tmp.zwhen.tmp.a….tmp.xalready exist..tmp.a….tmp.zfiles exist.#if 0in a ShaDa file forreference).