Skip to content

Fix < escape insertion in StflRichText#3008

Merged
dennisschagt merged 1 commit into
newsboat:masterfrom
juntuu:fix-stfl-rich-text-quoting
Feb 22, 2025
Merged

Fix < escape insertion in StflRichText#3008
dennisschagt merged 1 commit into
newsboat:masterfrom
juntuu:fix-stfl-rich-text-quoting

Conversation

@juntuu
Copy link
Copy Markdown
Contributor

@juntuu juntuu commented Feb 22, 2025

Fixes #3007

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 60.989% (+0.02%) from 60.97%
when pulling d0b6a02 on juntuu:fix-stfl-rich-text-quoting
into 29c031a on newsboat:master.

Copy link
Copy Markdown
Member

@dennisschagt dennisschagt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, LGTM

@dennisschagt dennisschagt merged commit d0e8738 into newsboat:master Feb 22, 2025
@juntuu juntuu deleted the fix-stfl-rich-text-quoting branch February 22, 2025 19:03
@Minoru Minoru added this to the 2.39 milestone Mar 25, 2025
senatoreg pushed a commit to senatoreg/newsboat that referenced this pull request Apr 1, 2025
Release Newsboat 2.39

Added
=====

- New `bind` command, which is an improvement on both `bind-key` and `macro`.
    It allows multi-key bindings (that's new!) which execute one or more actions
    (similar to macros), and can have a description that'll be displayed in the
    help dialog (that's new too!). It also offers an additional syntax for
    specifying keys: instead of `^R`, one can write `<C-r>`. Multi-key bindings
    are slightly limited in that bindings with same prefix must all be the same
    length to avoid ambiguity when executing them (if I had bindings `for` and
    `fork`, and typed `for`, Newsboat wouldn't know if that's it or I'm going to
    type `k` next) (newsboat#1165) (Dennis van der Schagt, Alexander Batischev, Lysander
    Trischler)
- contrib/newsboat-idlefeeds.sh: a script to show feeds that weren't updated in
    a given amount of time (T3SQ8)

Changed
=======

- Highlighting in the help form is now case-insensitive (newsboat#2998) (Juho Eerola)
- Updated translations: Dutch (Dennis van der Schagt),
    German (Lysander Trischler), Italian (Mauro Scomparin), Polish (Carno),
    Russian and Ukrainian (Alexander Batischev), Swedish (Dennis Öberg),
    Turkish (Emir SARI)
- Bumped minimum supported Rust version to 1.81.0

Deprecated
==========

- Compilers that don't support C++17. This release compiles with `-std=c++17`,
    but only for compatibility with header files of libicu 75+; Newsboat itself
    only uses C++14 for now. The next release might start using C++17 features,
    so please open an issue if that'll cause problems for you (newsboat#3031) (Alexander
    Batischev)

Removed
=======

- Support for Clang 4, because it doesn't accept `-std=c++17` (newsboat#3031) (Alexander
    Batischev)

Fixed
=====

- Crash when setting a non-existent variable (newsboat#2989) (Dennis van der Schagt)
- Highlights not displayed for searches that contain less-than sign, due to
    errors in quoting (newsboat#3008) (Juho Eerola)
- Building with libicu 75+, which requires C++17. libicu is an indirect
    dependency of Newsboat via libxml2 (newsboat#3031) (Alexander Batischev)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StflRichText::quoted() loses tags immediately following a literal <

4 participants