Skip to content

unified cgroup support #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vlvkobal merged 9 commits into from
Apr 9, 2019
Merged

unified cgroup support #5407

vlvkobal merged 9 commits into from
Apr 9, 2019

Conversation

@skrzyp1
Copy link
Contributor

@skrzyp1 skrzyp1 commented Feb 17, 2019 •
edited by cakrit
Loading

Summary

Fixes #3750

Component Name
Additional Information

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netdatabot netdatabot added the area/collectors Everything related to data collection label Feb 18, 2019
@cakrit
Copy link
Contributor

cakrit commented Feb 18, 2019

I edited the first comment to add the reference to the issue.

@vlvkobal vlvkobal mentioned this pull request Mar 25, 2019
Closed
@skrzyp1 skrzyp1 changed the title WiP unified cgroup support unified cgroup support Mar 29, 2019
@netdata netdata deleted a comment from netdatabot Apr 1, 2019
@netdata netdata deleted a comment from netdatabot Apr 1, 2019
vlvkobal
vlvkobal previously approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@vlvkobal vlvkobal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and read line by line.
@skrzyp1 don't you want to implement CPU limits? As I see, cgroup v2 provides cpu.max.

@skrzyp1
Copy link
Contributor Author

skrzyp1 commented Apr 3, 2019

@vlvkobal I can implement them too, just wanted to have this part merged so there will be no merge conflicts when other people edit. I can do that as a separate issue is that ok?

cakrit
cakrit suggested changes Apr 4, 2019
View reviewed changes
@vlvkobal
Copy link
Contributor

vlvkobal commented Apr 4, 2019 •
edited
Loading

I can do that as a separate issue is that ok?

It is OK. But please update the documentation in this PR.

@skrzyp1
Copy link
Contributor Author

skrzyp1 commented Apr 8, 2019

@cakrit I removed unused variable. @vlvkobal I added info to docs. Is everything ok now?

@vlvkobal vlvkobal merged commit 6724b63 into netdata:master Apr 9, 2019
@vlvkobal vlvkobal mentioned this pull request Apr 12, 2019
Closed
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
@skrzyp1 @jackyhuang85
unified cgroup support (netdata#5407)
b711aed 
* WiP unified cgroup support

* add cpu usage support and disk iops support

* memory limits

* WIP working memory charts

* detailed memory chart

* docs change
@rbjorklin rbjorklin mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktsaou ktsaou Awaiting requested review from ktsaou

2 more reviewers

@vlvkobal vlvkobal vlvkobal approved these changes

@cakrit cakrit cakrit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/collectors Everything related to data collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skrzyp1 @CLAassistant @cakrit @vlvkobal @netdatabot