update packages #78
Merged
update packages #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCM report✅ no issues found! Full report: https://github.com/netglade/glade_forms/runs/35920983762 |
tenhobi
requested changes
Jan 17, 2025
glade_forms/analysis_options.yaml
Outdated
Comment on lines
11
to
15
| prefer-boolean-prefixes: false # TODO | ||
| prefer-abstract-final-static-class: false # TODO | ||
| prefer-named-parameters: false # TODO | ||
| dispose-class-fields: false # TODO | ||
| avoid-undisposed-instances: false # TODO |
glade_forms/analysis_options.yaml
Outdated
| prefer-abstract-final-static-class: false # TODO | ||
| prefer-named-parameters: false # TODO | ||
| dispose-class-fields: false # TODO | ||
| avoid-undisposed-instances: false # TODO |
Member
There was a problem hiding this comment.
- avoid-undisposed-instances: ignored-invocations settings https://dcm.dev/docs/rules/flutter/avoid-undisposed-instances
- dispose-class-fields: ignore comment, i would type there something like that "callback parameters are better without named"
- prefer-abstract-final-static-class: fix
- prefer-boolean-prefixes: ok to disable (breaks API), or maybe just ignore comments on line/file?
- avoid-commented-out-code: above the comment add "// TODO(alternative): you can also do this" or something like that, to disable the warning
- prefer-single-declaration-per-file: add ignore for the one case
tenhobi
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.