Remove redundant $service variable in case of simply service without dependencies.#206
Closed
janbarasek wants to merge 2 commits into
Closed
Remove redundant $service variable in case of simply service without dependencies.#206janbarasek wants to merge 2 commits into
janbarasek wants to merge 2 commits into
Conversation
…dependencies.
In case of:
```php
public function createServiceMyService(): Model\MyService
{
$service = new Model\MyService;
return $service;
}
```
Generate simplify version:
```php
public function createServiceMyService(): Model\MyService
{
return new Model\MyService;
}
```
And in case of simple static service:
```php
public function createServiceMyService(): Model\MyService
{
$service = Model\MyServiceFactory::getInstance();
return $service;
}
```
Generate:
```
public function createServiceMyService(): Model\MyService
{
return Model\MyServiceFactory::getInstance();
}
```
4248460 to
2378ea6
Compare
Member
|
I think it would be cleaner to deal with this in |
fecd1fb to
15978c3
Compare
dg
added a commit
that referenced
this pull request
Jul 24, 2019
dg
added a commit
that referenced
this pull request
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of:
Generate simplify version:
And in case of simple static service:
Generate: