Skip to content

fix: Properly set random icon on load #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
enjeck merged 1 commit into from
Apr 25, 2024
Merged

fix: Properly set random icon on load #1001

enjeck merged 1 commit into from
Apr 25, 2024

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Apr 25, 2024 •
edited
Loading

We used to set the icon on load to the promise returned by setIcon, so without changing the icon the creation failed.

Fix #1000

@juliusknorr
fix: Properly set random icon on load
3f41086 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr requested review from elzody and enjeck and removed request for enjeck April 25, 2024 11:25
@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Apr 25, 2024
@juliusknorr juliusknorr mentioned this pull request Apr 25, 2024
Closed
@juliusknorr juliusknorr requested a review from enjeck April 25, 2024 11:32
@juliusknorr juliusknorr self-assigned this Apr 25, 2024
enjeck
enjeck approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@enjeck enjeck merged commit 937caea into main Apr 25, 2024
@enjeck enjeck deleted the fix/1000 branch April 25, 2024 14:08
@enjeck enjeck mentioned this pull request Apr 26, 2024
Closed
@blizzz
Copy link
Member

blizzz commented Apr 30, 2024

/backport to stable0.7

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Apr 30, 2024
@backportbot backportbot bot mentioned this pull request Apr 30, 2024
Merged
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enjeck enjeck enjeck approved these changes

@elzody elzody Awaiting requested review from elzody

Assignees

@juliusknorr juliusknorr

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

📝 Office team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Message":"OCA\\Tables\\Controller\\ContextController::create(): Argument #2 ($iconName) must be of type string, array given, called in

4 participants

@juliusknorr @blizzz @enjeck