Skip to content

feat: Enhance "Contains" filter to support "selection" type #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from
Jun 11, 2025
Merged

feat: Enhance "Contains" filter to support "selection" type #1798

blizzz merged 1 commit into from
Jun 11, 2025

Conversation

@AIlkiv
Copy link
Contributor

@AIlkiv AIlkiv commented May 4, 2025 •
edited
Loading

I think this filter will improve the UX. Because now you don't have to remember the exact value.

image

@AIlkiv AIlkiv requested review from blizzz and enjeck as code owners May 4, 2025 17:19
@AIlkiv AIlkiv force-pushed the feat/selection-column-contains-filter branch from 9a59f77 to 8e5a580 Compare May 5, 2025 05:38
@AIlkiv AIlkiv changed the title feat: Enhance Contains filter to support additional selection type feat: Enhance "Contains" filter to support "selection" type May 5, 2025
@AIlkiv AIlkiv force-pushed the feat/selection-column-contains-filter branch from 8e5a580 to ea2e597 Compare May 5, 2025 06:38
@Koc Koc force-pushed the feat/selection-column-contains-filter branch from ea2e597 to 2a3b699 Compare May 10, 2025 15:49
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

blizzz
blizzz approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works

@AIlkiv @blizzz
feat: Enhance Contains filter to support additional selection type an…
2ca42a9 
…d improve case-insensitive matching

Signed-off-by: ailkiv <a.ilkiv.ye@gmail.com>
@blizzz blizzz force-pushed the feat/selection-column-contains-filter branch from 2a3b699 to 2ca42a9 Compare May 23, 2025 09:05
@AIlkiv
Copy link
Contributor Author

AIlkiv commented May 29, 2025

@enjeck please look at this MR.

@blizzz blizzz merged commit 591108e into nextcloud:main Jun 11, 2025
60 of 67 checks passed
@juliusknorr juliusknorr added the enhancement New feature or request label Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@enjeck enjeck Awaiting requested review from enjeck enjeck is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AIlkiv @blizzz @juliusknorr