[stable0.8] refactor(Controller): remove private ColumnsController #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
approved these changes
May 23, 2025
enjeck
approved these changes
May 28, 2025
… and use the Api1 instead. This one is also involved in integration tests while the ColumnsController not and could have only be used in the front- end anyways. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
c2d63b1 to
f8145cf
Compare
kieuduyan
reviewed
May 28, 2025
| if ($columnDto->getTitle() !== null) { | ||
| $item->setTitle($columnDto->getTitle()); | ||
| } | ||
| if ($tableId !== null) { |
| }, | ||
| async removeColumn({ state, commit }, { id, isView, elementId }) { | ||
| try { | ||
| await axios.delete(generateUrl('/apps/tables/column/' + id)) |
There was a problem hiding this comment.
await axios.delete(generateUrl('/apps/table/column/' + id));
| try { | ||
| $item = $this->columnService->update( | ||
| $columnId, | ||
| null, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and use the Api1 instead. This one is also involved in integration tests while the ColumnsController not and could have only be used in the front- end anyways.