Skip to content

fix: Smartpicker show content #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
enjeck merged 8 commits into from
Jul 29, 2025
Merged

fix: Smartpicker show content #1836

enjeck merged 8 commits into from
Jul 29, 2025

Conversation

@enjeck
Copy link
Contributor

@enjeck enjeck commented Jun 7, 2025 •
edited
Loading

fixes #1802

TODO

@enjeck enjeck requested a review from juliusknorr June 7, 2025 12:29
@enjeck enjeck self-assigned this Jun 7, 2025
@enjeck enjeck requested a review from blizzz as a code owner June 7, 2025 12:29
@enjeck enjeck added the 3. to review Waiting for reviews label Jun 7, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jun 7, 2025
@enjeck enjeck mentioned this pull request Jun 7, 2025
Closed
@blizzz blizzz requested a review from a team June 30, 2025 07:08
This was referenced Jul 17, 2025
Closed
Closed
@enjeck enjeck mentioned this pull request Jul 28, 2025
Closed
enjeck added 4 commits July 28, 2025 19:02
@enjeck
fix: Properly display Tables smartpicker content
48a31fd 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix: Allow searching for text for any length
0f19bc3 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix: console errors due to reading properties of null/undefined
5090353 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix: Format and remove unused defs
d3923fc 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
enjeck added 4 commits July 28, 2025 19:44
@enjeck
fix: smartpicker styling
6b7a376 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix: Properly update rows
7b209f7 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix: Add SPDX header
36cf67e 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix: Change test to look for existence
d21b94c 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck enjeck requested a review from elzody July 29, 2025 04:52
@enjeck enjeck added the bug Something isn't working label Jul 29, 2025
blizzz
blizzz approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@enjeck enjeck merged commit 65bbafb into main Jul 29, 2025
50 checks passed
@enjeck enjeck deleted the fix/1802 branch July 29, 2025 18:01
@github-project-automation github-project-automation bot moved this from 🧭 Planning evaluation (don't pick) to ☑️ Done in 📝 Office team Jul 29, 2025
@enjeck
Copy link
Contributor Author

enjeck commented Jul 31, 2025

/backport to stable0.9

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jul 31, 2025
@backportbot backportbot bot mentioned this pull request Jul 31, 2025
Merged
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@elzody elzody Awaiting requested review from elzody

Assignees

@enjeck enjeck

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

📝 Office team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Smart picker does not fetch or show content

3 participants

@enjeck @blizzz