Add "Internal Link" Sharing Tile with Copy-to-Clipboard #1831
Conversation
23e06b7 to
a6a3959
Compare
enjeck
left a comment
There was a problem hiding this comment.
Can you please also attach a picture of what the UI looks like?
juliusknorr
left a comment
There was a problem hiding this comment.
Thanks a lot for the pull request, this looks very good already. I've left a few minor comments on the code itself and one note about a functional issue. Could you have another quick look at those?
|
And just to mention, there is some flakyness in the cypress and phpunit tests right now, so those failures would be something @enjeck can check and tell if they are related to the change or not. |
b4bde6f to
5159f0a
Compare
Thank you @juliusknorr ! I have implemented the suggested changes :) |
|
Thanks a lot. Could you have a look at the failing REUSE and eslint checks? Those two seem related to the changes, the others can be ignored for now (or a rebase to the latest main branch may solve them) |
| if (!this.activeElement) { | ||
| return '' | ||
| } | ||
| const baseUrl = generateUrl('/apps/tables/', {}, { baseURL: window.location.origin }) |
There was a problem hiding this comment.
| const baseUrl = generateUrl('/apps/tables/', {}, { baseURL: window.location.origin }) | |
| const baseUrl = generateUrl('/apps/tables/') |
There was a problem hiding this comment.
In more or less two hours I'll have time to work on that and the failing checks!
There was a problem hiding this comment.
I used baseURL: window.location.origin when calling generateUrl to ensure the generated URL works correctly in my local development environment, where relative paths like /index.php/... were resolving incorrectly (e.g., resulting in a file:/// URL instead of http://localhost).
juliusknorr
left a comment
There was a problem hiding this comment.
One nitpick and two ci failures, but otherwise this is good to get in already from my side 👍
|
@silverkszlo For the Cypress checks, those are flaky and would pass upon rerunning, so you need not worry about them |
|
To fix other CI fails:
|
5159f0a to
23bb581
Compare
Signed-off-by: silverkszlo <paguaro@posteo.eu>
Signed-off-by: silverkszlo <paguaro@posteo.eu>
Signed-off-by: silverkszlo <paguaro@posteo.eu>
23bb581 to
386c86d
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This PR introduces a new sharing option component called "Internal Link", which allows users to copy a direct link to the currently selected table or view. This feature is useful for quickly sharing internal resources with users who already have access to the folder.
Features: