Skip to content

Conversation

@enjeck
Copy link
Contributor

@enjeck enjeck commented Aug 5, 2025

Part of #364

Supports inline editing for the Selection and MultiSelection column types

TODO

@enjeck enjeck self-assigned this Aug 5, 2025
@enjeck enjeck added enhancement New feature or request 2. developing Work in progress labels Aug 5, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Aug 5, 2025
@enjeck enjeck mentioned this pull request Aug 5, 2025
17 tasks
Base automatically changed from feat/364 to main August 5, 2025 07:29
@enjeck enjeck changed the base branch from main to remove-nbsp August 6, 2025 03:51
@enjeck enjeck force-pushed the feat/364-selection branch from 5318dec to 77cb2cb Compare August 6, 2025 03:51
@enjeck enjeck changed the base branch from remove-nbsp to main August 14, 2025 03:53
@enjeck enjeck force-pushed the feat/364-selection branch from 77cb2cb to 5de184d Compare August 14, 2025 03:53
@enjeck enjeck marked this pull request as ready for review August 14, 2025 04:56
@enjeck enjeck requested a review from blizzz as a code owner August 14, 2025 04:56
@enjeck
Copy link
Contributor Author

enjeck commented Aug 14, 2025

Here's how it works:
Screencast from 2025-08-14 05-37-14.webm

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the broken border in the dropdown, that would be something we have to fix.
A nice-to-have: in view mode show the multiple options styled as user bubbles, similar to how they are shown in the dropdown. Currently they are shown as bullet list items which looks very different. Can also be in a follow up

@enjeck
Copy link
Contributor Author

enjeck commented Aug 17, 2025

in view mode show the multiple options styled as user bubbles, similar to how they are shown in the dropdown. Currently they are shown as bullet list items which looks very different. Can also be in a follow up

Yes, would have to be done as a follow up since this is unrelated to inline editing itself as the view mode has always looked like this

initEditValue() {
if (this.value !== null) {
this.editValue = this.getOptionObject(parseInt(this.value))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is parseInt here necessary if value is already a Number (in props)?

Copy link
Contributor

@silverkszlo silverkszlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely!

enjeck added 4 commits August 18, 2025 19:18
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
…ction components

Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck enjeck force-pushed the feat/364-selection branch from c37d7c1 to c7ddc9f Compare August 18, 2025 18:18
@enjeck enjeck merged commit 760151c into main Aug 18, 2025
50 of 56 checks passed
@enjeck enjeck deleted the feat/364-selection branch August 18, 2025 19:16
@github-project-automation github-project-automation bot moved this from 🧭 Planning evaluation (don't pick) to ☑️ Done in 📝 Office team Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants