Skip to content

test: added a test for remove filtered rows feature #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from
Aug 15, 2025
Merged

test: added a test for remove filtered rows feature #1998

blizzz merged 1 commit into from
Aug 15, 2025

Conversation

@benjaminfrueh
Copy link
Contributor

@benjaminfrueh benjaminfrueh commented Aug 12, 2025

Added a test for the feature that removes rows from a view when they no longer match the filter. The test covers the following steps:

  • create a view with filter for checked == true
  • insert a "checked row", check server response for present to be true and DOM for be.visible
  • insert a "unchecked row", check server response for present to be false and DOM for not.exists
  • edit the "checked row", uncheck it, check server response for present to be false and DOM for not.exists
  • inline edit "first row" (from the setup table), uncheck it, check response for present to be false and DOM for not.exists

@benjaminfrueh
test: add a test for remove filtered rows feature
aa626a6 
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish tests labels Aug 13, 2025
@blizzz blizzz merged commit eae88cd into nextcloud:main Aug 15, 2025
50 of 52 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@enjeck enjeck Awaiting requested review from enjeck enjeck is a code owner

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feedback-requested tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benjaminfrueh @blizzz