Skip to content

fix: Export JSON scheme #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 7 commits into from
Oct 13, 2025
Merged

fix: Export JSON scheme #2075

blizzz merged 7 commits into from
Oct 13, 2025

Conversation

@enjeck
Copy link
Contributor

@enjeck enjeck commented Sep 25, 2025

Right now, if you select the "Export" option for a table, you get the error

Trace
#0 /var/www/html/lib/private/AppFramework/Http/Dispatcher.php(227): OCP\AppFramework\Controller->buildResponse(Object(OCP\AppFramework\Http\DataResponse), 'xhtml+xml')
#1 /var/www/html/lib/private/AppFramework/Http/Dispatcher.php(118): OC\AppFramework\Http\Dispatcher->executeController(Object(OCA\Tables\Controller\Api1Controller), 'showScheme')
#2 /var/www/html/lib/private/AppFramework/App.php(153): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\Tables\Controller\Api1Controller), 'showScheme')
#3 /var/www/html/lib/private/Route/Router.php(321): OC\AppFramework\App::main('OCA\Tables\Cont...', 'showScheme', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
#4 /var/www/html/lib/base.php(1061): OC\Route\Router->match('/apps/tables/ap...')
#5 /var/www/html/index.php(25): OC::handleRequest()
#6 {main}

This fixes it.

@enjeck enjeck self-assigned this Sep 25, 2025
@enjeck enjeck requested a review from blizzz as a code owner September 25, 2025 05:29
@enjeck enjeck added bug Something isn't working 3. to review Waiting for reviews labels Sep 25, 2025
blizzz
blizzz reviewed Sep 26, 2025
View reviewed changes
@blizzz
Copy link
Member

blizzz commented Sep 26, 2025

Is this related to the otherwise failing tables-import-export-scheme.cy.js test?

@elzody elzody linked an issue Sep 30, 2025 that may be closed by this pull request
Exporting a table causes an internal server error #2088
Closed
@enjeck enjeck force-pushed the fix-export-scheme branch from 072775e to 28aabb8 Compare October 2, 2025 06:13
@enjeck
Copy link
Contributor Author

enjeck commented Oct 2, 2025

Is this related to the otherwise failing tables-import-export-scheme.cy.js test?

Looks like it!

blizzz
blizzz requested changes Oct 6, 2025
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a JSONResponse class, please use this instead of DataResponse then. But we can instantiate it normally and don't need to instantiate an anonymous class on the fly.

@enjeck enjeck force-pushed the fix-export-scheme branch from f848fed to 02dc9f4 Compare October 7, 2025 04:33
blizzz
blizzz reviewed Oct 7, 2025
View reviewed changes
@enjeck enjeck force-pushed the fix-export-scheme branch from 9b71893 to 22109d5 Compare October 9, 2025 07:44
@enjeck enjeck requested a review from blizzz October 10, 2025 05:13
enjeck added 7 commits October 10, 2025 06:13
@enjeck
fix: Export JSON scheme
bf87e9f 
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
@enjeck
fix: lint and openapi
e241abf 
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
@enjeck
fix: update return type and annotations for showScheme method
0cf3ce5
@enjeck
fix: update response handling and return type for table scheme method
dcbb037
@enjeck
fix: Use JSONResponse
de642be 
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
@enjeck
fix: openapi
63e9578 
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
@enjeck
fix: Use Tablestable psalm type instead of array
c5d3668 
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
@enjeck enjeck force-pushed the fix-export-scheme branch from 22109d5 to c5d3668 Compare October 10, 2025 05:13
@blizzz blizzz merged commit dd2055a into main Oct 13, 2025
68 checks passed
@blizzz blizzz deleted the fix-export-scheme branch October 13, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

Assignees

@enjeck enjeck

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exporting a table causes an internal server error

3 participants

@enjeck @blizzz