Skip to content

enh: Polish inline editing fields #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 2 commits into from
Nov 11, 2025
Merged

enh: Polish inline editing fields #2095

blizzz merged 2 commits into from
Nov 11, 2025

Conversation

@enjeck
Copy link
Contributor

@enjeck enjeck commented Oct 6, 2025 •
edited
Loading

Fixes some of #2054

  • Richtext: There should be no jump in the whole table when a user clicks in and out an inline editable field
  • Textline: Fields should activate edit mode with just one click
  • Richtext: We should not show drag handles or + icons in text fields that are not currently being edited
  • Stars: The stars shouldn't change in style and size, they should stay of --color-main-text and with the same distance
  • Switch: Don't show scrollbars
  • When editing rich text inline, some things are clipped (like when creating a heading the # icon). It also has a big black border it isn't supposed to have.

The last point was reported at #2089

@enjeck enjeck requested a review from marcoambrosini October 6, 2025 18:35
@enjeck enjeck self-assigned this Oct 6, 2025
@enjeck enjeck requested a review from blizzz as a code owner October 6, 2025 18:35
@enjeck enjeck added the 3. to review Waiting for reviews label Oct 6, 2025
This was referenced Oct 6, 2025
Open
Open
@enjeck enjeck requested a review from silverkszlo October 14, 2025 09:32
@blizzz blizzz force-pushed the polish-inline-editing branch from ee35c09 to d3f66bd Compare October 14, 2025 09:36
silverkszlo
silverkszlo reviewed Oct 15, 2025
View reviewed changes
@silverkszlo

This comment was marked as resolved.

Sign in to view
@juliusknorr juliusknorr moved this to 🏗️ In progress in 📝 Office team Oct 21, 2025
@enjeck enjeck force-pushed the polish-inline-editing branch 2 times, most recently from d5988e2 to adfe430 Compare October 23, 2025 07:12
@enjeck enjeck requested a review from silverkszlo October 23, 2025 07:12
@enjeck enjeck force-pushed the polish-inline-editing branch 2 times, most recently from 724d18b to 7a7a851 Compare October 29, 2025 05:10
enjeck added 2 commits October 30, 2025 09:03
@enjeck
enh: Polish inline editing fields
4c9cf2f 
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
@enjeck
fix: Move logic to computed, fix tests
fad982d 
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
@enjeck enjeck force-pushed the polish-inline-editing branch from 7a7a851 to fad982d Compare October 30, 2025 09:03
silverkszlo
silverkszlo approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@silverkszlo silverkszlo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you! I have tested UI and it all seems to work.

@blizzz blizzz merged commit 0829adb into main Nov 11, 2025
53 of 58 checks passed
@blizzz blizzz deleted the polish-inline-editing branch November 11, 2025 18:47
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silverkszlo silverkszlo silverkszlo approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

Assignees

@enjeck enjeck

Labels

3. to review Waiting for reviews

Projects

📝 Office team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@enjeck @silverkszlo @blizzz