Fix mkdocs build output path in docs-release workflow#818
Merged
Conversation
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Nextflow linting complete! ❌ 1 files had 1 errors 💡 Tip: Click filename locations to go directly to that code. View all 1 issues
View formatting changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs-release.yml, matching the fix applied todocs-dev.ymlin Consolidate translation workflows and fix docs-dev checkout #813Problem
The release workflow was using a relative path (
-d site-${{ matrix.lang }}), but mkdocs interprets this relative to the config file location (docs/en/mkdocs.yml), causing output to go todocs/en/site-en/instead of the repo root whereupload-artifactexpected it.This caused all artifact uploads to fail with "No files were found with the provided path", resulting in the deploy job failing.
Fix
Changed from:
mkdocs build -f docs/${{ matrix.lang }}/mkdocs.yml -d site-${{ matrix.lang }}To:
mkdocs build -f docs/${{ matrix.lang }}/mkdocs.yml -d ${{ github.workspace }}/site-${{ matrix.lang }}This matches the approach used in
docs-dev.ymlafter #813.Fixes the failure in https://github.com/nextflow-io/training/actions/runs/21628227613/job/62333885769