Bump nf-co2footprint to 1.3.0, remove config-warning workaround#950
Draft
pinin4fjords wants to merge 1 commit into
Draft
Bump nf-co2footprint to 1.3.0, remove config-warning workaround#950pinin4fjords wants to merge 1 commit into
pinin4fjords wants to merge 1 commit into
Conversation
The 1.3.0 release registers `CO2FootprintConfig` as a `ConfigScope` extension point, so the cosmetic `WARN: Unrecognized config option 'co2footprint.location'` no longer appears. Drop the note that told learners to ignore it. 1.3.0 requires Nextflow >=26.04.0, so bump NXF_VER in the devcontainer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Nextflow linting complete!
💡 Tip: Click filename locations to go directly to that code. View all 53 issuesView formatting changes<...*[Comment body truncated]*
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nf-co2footprintplugin pin in the plugin-basics side quest from1.2.0to1.3.0.!!! noteadmonition that told learners to ignore the cosmeticWARN: Unrecognized config option 'co2footprint.location'message.NXF_VERin.devcontainer/devcontainer.jsonfrom25.10.4to26.04.0(required by plugin 1.3.0, see below).The upstream fix landed in nf-co2footprint 1.3.0:
Draft - Nextflow version implication
nf-co2footprint@1.3.0declares a minimum Nextflow version of26.04.0, so the devcontainer pin had to move up too. Confirmed locally:After bumping
NXF_VER=26.04.0, the plugin loads cleanly and the cosmetic warning is gone.This is left as draft because bumping
NXF_VERwill affect every other tutorial underdocs/en/. There are roughly 30+ console-output snippets acrosshello_nextflow/,nf4_science/, etc. that showN E X T F L O W ~ version 25.10.x, plus prose like "This training is designed for Nextflow 25.10.x or later" inindex.mdand orientation pages. Those will look stale to anyone running the training off this branch.Open questions for reviewers:
25.10.xreferences) before merging this?Test plan
ghcr.io/nextflow-io/training:latest,NXF_VER=26.04.0) thatnextflow run hello.nfagainst the section 3.4 config emits noUnrecognized config optionwarning.163.92 gCO₂eq/kWh) is still applied as documented.🤖 Generated with Claude Code