Skip to content

Migrate to new syntax #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvnieuwk merged 14 commits into from
Nov 26, 2024
Merged

Migrate to new syntax #24

nvnieuwk merged 14 commits into from
Nov 26, 2024

Conversation

@nvnieuwk
Copy link
Member

@nvnieuwk nvnieuwk commented Nov 26, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nvnieuwk nvnieuwk requested a review from ToonRosseel November 26, 2024 10:59
ToonRosseel
ToonRosseel approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@ToonRosseel ToonRosseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remarks 🔥

@nvnieuwk nvnieuwk merged commit 6170de1 into dev Nov 26, 2024
33 checks passed
@nvnieuwk nvnieuwk deleted the migrate-to-new-syntax branch November 26, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToonRosseel ToonRosseel ToonRosseel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nvnieuwk @ToonRosseel