Skip to content

rename pool to batch #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ToonRosseel merged 5 commits into from
Nov 28, 2024
Merged

rename pool to batch #25

ToonRosseel merged 5 commits into from
Nov 28, 2024

Conversation

@ToonRosseel
Copy link
Collaborator

@ToonRosseel ToonRosseel commented Nov 26, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ToonRosseel ToonRosseel requested a review from nvnieuwk November 26, 2024 16:19
@ToonRosseel ToonRosseel linked an issue Nov 27, 2024 that may be closed by this pull request
Fix wording in samplesheet and workflow #23
Closed
nvnieuwk
nvnieuwk approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small remark

@ToonRosseel ToonRosseel merged commit 01b498a into nf-cmgg:dev Nov 28, 2024
33 checks passed
@ToonRosseel ToonRosseel deleted the rename_header_samplesheet_pool branch November 28, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix wording in samplesheet and workflow

2 participants

@ToonRosseel @nvnieuwk