Skip to content

Conversation

@nvnieuwk
Copy link
Member

@nvnieuwk nvnieuwk commented Dec 6, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nvnieuwk nvnieuwk requested a review from ToonRosseel December 6, 2024 13:44
Copy link
Collaborator

@ToonRosseel ToonRosseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small - not holding - comment

@ToonRosseel ToonRosseel merged commit d748611 into dev Dec 12, 2024
32 of 33 checks passed
@nvnieuwk nvnieuwk deleted the final-fixes branch December 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants