Skip to content

Fix #452: publishDir collisions between PRESTO_PARSE_CLUSTER and PRESTO_PAIRSEQ_CLUSTERSETS#453

Merged
tgelafr-pfzr merged 5 commits into
nf-core:devfrom
tgelafr-pfzr:bug/452-publishdir-overwrite
Mar 11, 2026
Merged

Fix #452: publishDir collisions between PRESTO_PARSE_CLUSTER and PRESTO_PAIRSEQ_CLUSTERSETS#453
tgelafr-pfzr merged 5 commits into
nf-core:devfrom
tgelafr-pfzr:bug/452-publishdir-overwrite

Conversation

@tgelafr-pfzr

@tgelafr-pfzr tgelafr-pfzr commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Closes #452, fixing collisions between publishDir locations of PRESTO_PARSE_CLUSTER_UMI and PRESTO_PAIRSEQ_CLUSTERSETS

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@tgelafr-pfzr tgelafr-pfzr requested a review from Copilot March 10, 2026 19:31
@tgelafr-pfzr tgelafr-pfzr changed the base branch from master to dev March 10, 2026 19:31
@tgelafr-pfzr tgelafr-pfzr reopened this Mar 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes output overwrites caused by publishDir collisions between PRESTO_PARSE_CLUSTER(_UMI) and PRESTO_PAIRSEQ_CLUSTERSETS in the PRESTO UMI subworkflow.

Changes:

  • Update PRESTO_PAIRSEQ_CLUSTERSETS publishDir to a dedicated subdirectory to avoid collisions.
  • Add an Unreleased changelog entry documenting the fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
conf/modules.config Moves PRESTO_PAIRSEQ_CLUSTERSETS published outputs under 05-parse-clusters/pairseq/ to prevent overwrites.
CHANGELOG.md Adds an Unreleased “Fixed” entry for the collision fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md Outdated
Comment thread conf/modules.config
@tgelafr-pfzr tgelafr-pfzr requested a review from ggabernet March 11, 2026 14:53

@ggabernet ggabernet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgelafr-pfzr Thank you for providing this fix!

Comment thread CHANGELOG.md Outdated
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
@tgelafr-pfzr tgelafr-pfzr merged commit aee871f into nf-core:dev Mar 11, 2026
14 checks passed
@tgelafr-pfzr tgelafr-pfzr deleted the bug/452-publishdir-overwrite branch March 11, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PublishDir overwrite errors

3 participants