Skip to content

fix: include all binners in dastool validation#1001

Merged
dialvarezs merged 3 commits into
nf-core:devfrom
dialvarezs:fix/dastool-check
Mar 23, 2026
Merged

fix: include all binners in dastool validation#1001
dialvarezs merged 3 commits into
nf-core:devfrom
dialvarezs:fix/dastool-check

Conversation

@dialvarezs

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@d4straub d4straub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These validation etc are just so distributed everywhere, so easy to overlook when adding tools

@dialvarezs dialvarezs merged commit 593b557 into nf-core:dev Mar 23, 2026
40 of 42 checks passed
@dialvarezs dialvarezs mentioned this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants