Skip to content

Bump 1.2.0dev#132

Merged
skrakau merged 4 commits into
nf-core:devfrom
skrakau:bump_1.2.0dev_2
Nov 18, 2020
Merged

Bump 1.2.0dev#132
skrakau merged 4 commits into
nf-core:devfrom
skrakau:bump_1.2.0dev_2

Conversation

@skrakau

@skrakau skrakau commented Nov 18, 2020

Copy link
Copy Markdown
Member

Bump 1.2.0dev

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo

@skrakau skrakau requested a review from d4straub November 18, 2020 09:11
@skrakau

skrakau commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

Applied changes by @KevinMenden from nf-core/tools#774 to avoid deprecated env usage and get CI tests working again.

@d4straub d4straub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Was before already wondering why checks are failing.

@skrakau

skrakau commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

me too :)

@KevinMenden

Copy link
Copy Markdown
Contributor

There was an error in the changes I made, you'll have to change the code slightly:
See here:
nf-core/tools#777

Basically exchange env.GIT_DIFF by env.MATCHED_FILES otherwise the docker image gets build all the time

@skrakau

skrakau commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

Thanks a lot @KevinMenden , was just about to change that :)

@KevinMenden

Copy link
Copy Markdown
Contributor

Sorry for the inconvenience :)

@skrakau

skrakau commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

Thanks to you for updating the CI and keeping us informed!

@skrakau skrakau merged commit 98d5aa0 into nf-core:dev Nov 18, 2020
@skrakau skrakau deleted the bump_1.2.0dev_2 branch May 31, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants