Skip to content

fix: metabat2 failed on fusion file systems#493

Merged
adamrtalbot merged 2 commits into
nf-core:devfrom
adamrtalbot:update_metabat2_module
Aug 14, 2023
Merged

fix: metabat2 failed on fusion file systems#493
adamrtalbot merged 2 commits into
nf-core:devfrom
adamrtalbot:update_metabat2_module

Conversation

@adamrtalbot

@adamrtalbot adamrtalbot commented Aug 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Updates metabat2 module which fixes a bug when using virtual file systems like Fusion.
  • Confirmed to work on an AWS + Fusion test compute env.

@github-actions

github-actions Bot commented Aug 11, 2023

Copy link
Copy Markdown

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @adamrtalbot,

It looks like this pull-request is has been made against the adamrtalbot/mag master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the adamrtalbot/mag dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@adamrtalbot adamrtalbot changed the base branch from master to dev August 11, 2023 14:34
@adamrtalbot adamrtalbot changed the title fix: Using on fusion file systems fix: metabat2 failed on fusion file systems Aug 11, 2023
@github-actions

github-actions Bot commented Aug 11, 2023 •
edited
Loading

Copy link
Copy Markdown

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 213516f

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-14 09:18:40

@asp8200

asp8200 commented Aug 12, 2023

Copy link
Copy Markdown

Looks fine. Should the changelog also be updated?

FriederikeHanssen
FriederikeHanssen reviewed Aug 13, 2023
View reviewed changes
Comment thread modules/nf-core/metabat2/metabat2/main.nf
@adamrtalbot adamrtalbot merged commit e67b6a1 into nf-core:dev Aug 14, 2023
@adamrtalbot adamrtalbot deleted the update_metabat2_module branch August 14, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@asp8200 asp8200 asp8200 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamrtalbot @asp8200 @FriederikeHanssen