Skip to content

Patch release 3.0.2 for fixing BUSCO, CONCOCT and Docker container errors#635

Merged
jfy133 merged 23 commits into
masterfrom
dev
Jul 4, 2024
Merged

Patch release 3.0.2 for fixing BUSCO, CONCOCT and Docker container errors#635
jfy133 merged 23 commits into
masterfrom
dev

Conversation

@jfy133

@jfy133 jfy133 commented Jun 28, 2024

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions

github-actions Bot commented Jun 28, 2024

Copy link
Copy Markdown

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4e12465

+| ✅ 306 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   6 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 3.0.2
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-04 06:37:30

Comment thread CHANGELOG.md Outdated

@prototaxites prototaxites left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@christopher-hakkaart christopher-hakkaart self-requested a review July 3, 2024 13:55
Comment thread CHANGELOG.md Outdated

@christopher-hakkaart christopher-hakkaart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@jfy133

jfy133 commented Jul 4, 2024

Copy link
Copy Markdown
Member Author

Thank you @prototaxites @mashehu @christopher-hakkaart !

Comment thread CHANGELOG.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants