Skip to content

Fix missing GTDBTk files in outdir#673

Merged
jfy133 merged 2 commits into
devfrom
missing-gtdbtk-files
Sep 20, 2024
Merged

Fix missing GTDBTk files in outdir#673
jfy133 merged 2 commits into
devfrom
missing-gtdbtk-files

Conversation

@jfy133

@jfy133 jfy133 commented Sep 20, 2024

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions

github-actions Bot commented Sep 20, 2024 •
edited
Loading

Copy link
Copy Markdown

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit bfc2c0b

+| ✅ 306 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   5 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-20 12:57:16

d4straub
d4straub approved these changes Sep 20, 2024
View reviewed changes

@d4straub d4straub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread CHANGELOG.md Outdated
@jfy133 @d4straub
Update CHANGELOG.md
bfc2c0b 
Co-authored-by: Daniel Straub <42973691+d4straub@users.noreply.github.com>
@jfy133 jfy133 merged commit 48a3698 into dev Sep 20, 2024
@jfy133 jfy133 deleted the missing-gtdbtk-files branch September 20, 2024 13:32
@jfy133 jfy133 mentioned this pull request Oct 2, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4straub d4straub d4straub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jfy133 @d4straub