Skip to content

Fix quoting and undercore unused variables#724

Merged
dialvarezs merged 3 commits into
nf-core:devfrom
dialvarezs:fix-quotes
Dec 13, 2024
Merged

Fix quoting and undercore unused variables#724
dialvarezs merged 3 commits into
nf-core:devfrom
dialvarezs:fix-quotes

Conversation

@dialvarezs

@dialvarezs dialvarezs commented Dec 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

When I was looking at the code, I noticed some incorrectly placed quotes and corrected them. Additionally, I prefixed unused variables in this file with _ to suppress warnings reported by the language server.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

jfy133
jfy133 approved these changes Dec 6, 2024
View reviewed changes

@jfy133 jfy133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I can do from my phone :D

LGTM and definitely good to start doing the clean up of the code to make linting happy.

I was actually wondering if just before release we do one last PR (which I want to cut when your other big PR is in), of just fixes to make the language server and nf-core linting happy (we have a lot of warnings, particularly in the local modules). Do you think that would be worth it?

But for now this can be merged once you've added yourself to the contributors list on the README!

Comment thread subworkflows/local/utils_nfcore_mag_pipeline/main.nf Outdated
@dialvarezs

dialvarezs commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

I was actually wondering if just before release we do one last PR (which I want to cut when your other big PR is in), of just fixes to make the language server and nf-core linting happy (we have a lot of warnings, particularly in the local modules). Do you think that would be worth it?

Sure, I don't like seeing red things in the editor hahaha. I can give it a shot.

@dialvarezs dialvarezs merged commit 62d6f3d into nf-core:dev Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dialvarezs @jfy133