Skip to content

Use more robust method of database loading for GTDBTK#788

Merged
jfy133 merged 2 commits into
devfrom
udpate-gtdbtk
Apr 9, 2025
Merged

Use more robust method of database loading for GTDBTK#788
jfy133 merged 2 commits into
devfrom
udpate-gtdbtk

Conversation

@jfy133

@jfy133 jfy133 commented Apr 8, 2025

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 marked this pull request as ready for review April 8, 2025 09:03
@prototaxites

Copy link
Copy Markdown
Contributor

Is this listFiles() bit necessary now?

gtdb_dir = gtdb.listFiles()

@jfy133

jfy133 commented Apr 8, 2025

Copy link
Copy Markdown
Member Author

Ha good question... OK I'll test...

@dialvarezs dialvarezs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from Jim's question, it looks good for me!

@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit cd9dd7e

+| ✅ 334 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗  52 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.0
  • Run at 2025-04-09 08:59:53

@prototaxites prototaxites left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfy133

jfy133 commented Apr 9, 2025

Copy link
Copy Markdown
Member Author

It workeD!

@jfy133 jfy133 merged commit f14664e into dev Apr 9, 2025
@jfy133 jfy133 deleted the udpate-gtdbtk branch May 12, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants