Skip to content

note on '--tools' in Quickstart #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxulysse merged 5 commits into from
Aug 15, 2023
Merged

note on '--tools' in Quickstart #1166

maxulysse merged 5 commits into from
Aug 15, 2023

Conversation

@ATpoint
Copy link
Contributor

@ATpoint ATpoint commented Jul 28, 2023 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ATpoint ATpoint requested a review from maxulysse as a code owner July 28, 2023 08:30
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @ATpoint,

It looks like this pull-request is has been made against the ATpoint/sarek master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the ATpoint/sarek dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@ATpoint
Copy link
Contributor Author

ATpoint commented Jul 28, 2023

Mention --tools in Quickstart, responding to https://www.biostars.org/p/9570657/

@ATpoint ATpoint changed the base branch from master to dev July 28, 2023 08:32
@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0ba4cf5

+| ✅ 151 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-15 13:33:19

@asp8200
Copy link
Contributor

asp8200 commented Jul 28, 2023

@nf-core-bot fix linting please

@asp8200
Copy link
Contributor

asp8200 commented Jul 28, 2023

@ATpoint : Thanks for the PR. I'm afraid you should have made the PR from ATpoint:dev. Can you fix that?

@FriederikeHanssen
Copy link
Contributor

FriederikeHanssen commented Jul 28, 2023

Can you update the change log?

@maxulysse maxulysse merged commit 57a8026 into nf-core:dev Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ATpoint @asp8200 @FriederikeHanssen @maxulysse @nf-core-bot