fix: correct always-true lint condition and template doc typos#4324
Open
znorgaard wants to merge 2 commits into
Open
fix: correct always-true lint condition and template doc typos#4324znorgaard wants to merge 2 commits into
znorgaard wants to merge 2 commits into
Conversation
- linting.yml: the non-release lint step used `base_ref != 'master' || base_ref != 'main'`, which is always true (a value can't equal both), so the non-release lint also ran on release PRs to main/master. Use `&&` so it runs only when the base is neither. - CONTRIBUTING.md: fix broken `[Lint](lint)` checklist link -> `#lint-tests` (matches the correct anchor used earlier in the same file); remove a duplicate "the the". - usage.md: remove stray leading space inside the Wave Nextflow-version code span (`` ` 24.03.0-edge` `` -> `` `24.03.0-edge` ``). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small template fixes discovered while syncing a fastquourm to the 4.0.2 template. nf-core/fastquorum#150
.github/workflows/linting.yml— the non-release lint step guarded onif: ${{ github.base_ref != 'master' || github.base_ref != 'main' }}, which is always true (a value cannot equal bothmasterandmain, so at least one!=always holds). As a result the non-releasenf-core pipelines lintstep also ran on release PRs tomain/master, alongside the--releasestep. Changed to&&so it runs only when the base is neither.docs/CONTRIBUTING.md— fixed the broken[Lint](lint)checklist link to[Lint](#lint-tests)(the correct anchor, already used by the matching item earlier in the same file); removed a duplicate "the the".docs/usage.md— removed a stray leading space inside the Wave Nextflow-version code span (` 24.03.0-edge`→`24.03.0-edge`).No lint-rule logic or template structure changed; these are a CI-condition correctness fix and doc typo fixes.
PR checklist
CHANGELOG.mdis updateddocsis updated