raise if Singularity container retrieval fails#1622
Merged
fabianegli merged 5 commits intoJun 15, 2022
Merged
Conversation
4 tasks
Codecov Report
@@ Coverage Diff @@
## dev #1622 +/- ##
==========================================
- Coverage 64.44% 64.37% -0.07%
==========================================
Files 54 54
Lines 6288 6294 +6
==========================================
Hits 4052 4052
- Misses 2236 2242 +6
Continue to review full report at Codecov.
|
fabianegli
commented
Jun 1, 2022
mirpedrol
approved these changes
Jun 13, 2022
mirpedrol
left a comment
Member
There was a problem hiding this comment.
I think it's worth adding this change to CHANGELOG, otherwise it looks good to me
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been a test that xfailed - It seems that failing to retrieve a container image should have always raised an exception, but it didn't. Now it does and the test that was maked xfail is now split into two tests, one that tests the failure mode if Singularity isn't installed and one for the case Singularity is installed but the container image retrieval fails.
PR checklist
CHANGELOG.mdis updateddocsis updated