Skip to content

Cleanup licenses#1713

Closed
fabianegli wants to merge 5 commits into
nf-core:devfrom
fabianegli:cleanup-licenses
Closed

Cleanup licenses#1713
fabianegli wants to merge 5 commits into
nf-core:devfrom
fabianegli:cleanup-licenses

Conversation

@fabianegli

Copy link
Copy Markdown
Contributor

Closes #1712

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@fabianegli fabianegli added the WIP Work in progress label Jul 28, 2022
@fabianegli fabianegli changed the base branch from master to dev July 28, 2022 14:36
@github-actions

This comment was marked as outdated.

@codecov

codecov Bot commented Jul 28, 2022

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.22%. Comparing base (20ad2aa) to head (71025cc).
Report is 5021 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1713   +/-   ##
=======================================
  Coverage   69.22%   69.22%           
=======================================
  Files          59       59           
  Lines        7142     7142           
=======================================
  Hits         4944     4944           
  Misses       2198     2198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol

Copy link
Copy Markdown
Member

Hello, is this PR still a WIP? Or should we close it and open a new one changing the way the command nf-core licenses works? As you discussed in #1712

@fabianegli

Copy link
Copy Markdown
Contributor Author

Gulp this is an old one. The question in the linked issue seems to remain unanswered. Also, it is commented out code and as such should in my opinion not be merged. Only if there is a resolution about how to treat/retrieve the license information and the code becomes useful should it enter the repo. It was a bit of an exploration and experimentation and I currently don't have the capacity to work on this. In the current state this PR merely serves as a reminder that there is code to either remove or reactivate.

@mashehu

mashehu commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

surpassed by #3012

@mashehu mashehu closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is the licences functionality still desired/needed?

4 participants