NF-Core Sync includes template.yaml as option#1880
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
c0049b0 to
ad6e31b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ewels
approved these changes
Oct 5, 2022
ewels
left a comment
Member
There was a problem hiding this comment.
Nice! This is all that was required? Great!
I'd like to wait for the CI tests to run / pass, but reading the code LGTM 👍🏻 (haven't tested running)
Contributor
Author
|
I haven't added a new test - is that OK? I'm sure there are lots of edge cases but it works with a quick demo pipeline. |
Contributor
Author
|
Actually - it gets in a mess if the template file is in the repository. Relatively easy fix. |
added 2 commits
October 5, 2022 16:06
- Cache template.yml file before running nf-core sync. - If syncing fails, reset to start
…s into 1879_sync_template_yaml
Contributor
Author
|
@ewels @mirpedrol Please re-review, I've updated the code to cache the template YAML and re-write it during syncing which is a bit more involved and has to catch some exceptions. |
mirpedrol
approved these changes
Oct 12, 2022
mirpedrol
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates, it looks good! Feel free to merge when tests pass :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1879
Adds
-t/--template-yamltonf-core sync, so that users can update their pipeline based on existing template file.PR checklist
CHANGELOG.mdis updateddocsis updated