check_up_to_date() also checks for subworkflows#1934
Merged
Conversation
mashehu
approved these changes
Oct 11, 2022
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## dev #1934 +/- ##
=======================================
Coverage 60.03% 60.04%
=======================================
Files 37 37
Lines 4642 4640 -2
=======================================
- Hits 2787 2786 -1
+ Misses 1855 1854 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
check_up_to_date()function frommodules_json.pyalso checks for subworkflows.This also fixes the issue when installing a subworkflow from a new modules repo. To test:
close #1917
PR checklist
CHANGELOG.mdis updateddocsis updated