Improve test coverage of sync.py#1936
Merged
Merged
Conversation
There was a bug in this function: because `self.merge_branch` was used to store the new branch name, it was stored persistently in the `psync` object. Hence when a new branch was created, the branch number was appended several times, e.g. `original_merge_branch-2-3-4`.
Codecov Report
@@ Coverage Diff @@
## dev #1936 +/- ##
==========================================
+ Coverage 59.93% 61.26% +1.33%
==========================================
Files 37 37
Lines 4677 4642 -35
==========================================
+ Hits 2803 2844 +41
+ Misses 1874 1798 -76
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mashehu
approved these changes
Oct 12, 2022
mashehu
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the code coverage of the
syncmodule and fixes a couple of bugs along the way.Only the
syncfunction remains untested but this one is kind of a beast so I leave it for now.Closes #1913
PR checklist
CHANGELOG.mdis updated