Improve test coverage of __main__.py#1965
Merged
Merged
Conversation
mashehu
reviewed
Oct 25, 2022
mashehu
left a comment
Contributor
There was a problem hiding this comment.
just a quick look at it.
Codecov Report
@@ Coverage Diff @@
## dev #1965 +/- ##
==========================================
+ Coverage 61.13% 61.86% +0.72%
==========================================
Files 37 37
Lines 4678 4678
==========================================
+ Hits 2860 2894 +34
+ Misses 1818 1784 -34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f34944e to
ca1dd21
Compare
fabianegli
reviewed
Oct 26, 2022
Contributor
Author
|
Thanks for the comments, I think you can take another look now |
mashehu
reviewed
Oct 27, 2022
mashehu
approved these changes
Oct 27, 2022
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit test for the following commands:
list,launch,download,createandlint.The code of these commands is quite simple so what the tests do is mostly check that no cli arguments are forgotten and that they are passed along to the correct function.
Related to #1937
PR checklist
CHANGELOG.mdis updated