Skip to content

don't write file when applying a patch during update#2017

Merged
mirpedrol merged 10 commits into
nf-core:devfrom
mirpedrol:update-sha
Nov 14, 2022
Merged

don't write file when applying a patch during update#2017
mirpedrol merged 10 commits into
nf-core:devfrom
mirpedrol:update-sha

Conversation

@mirpedrol

Copy link
Copy Markdown
Member

Close #2014

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov

codecov Bot commented Nov 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2017 (800d180) into dev (8e81fe8) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2017      +/-   ##
==========================================
+ Coverage   63.84%   63.86%   +0.02%     
==========================================
  Files          41       41              
  Lines        4923     4923              
==========================================
+ Hits         3143     3144       +1     
+ Misses       1780     1779       -1     
Impacted Files Coverage Δ
nf_core/modules/modules_differ.py 84.92% <0.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mashehu

mashehu commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Could you maybe add a test for this?

@mirpedrol

Copy link
Copy Markdown
Member Author

Could you maybe add a test for this?

good idea :) I will add it before merging

Comment thread tests/modules/update.py
Comment thread tests/modules/update.py
mirpedrol and others added 3 commits November 11, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants