Skip to content

Activate work dir cleanup on successful completion#2163

Merged
jfy133 merged 2 commits into
devfrom
auto-cleanup-fulltest
Jan 20, 2023
Merged

Activate work dir cleanup on successful completion#2163
jfy133 merged 2 commits into
devfrom
auto-cleanup-fulltest

Conversation

@jfy133

@jfy133 jfy133 commented Jan 20, 2023

Copy link
Copy Markdown
Member

To help reduce AWS S3 maintainence and costs

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@jfy133 jfy133 changed the base branch from master to dev January 20, 2023 12:01
@github-actions

This comment was marked as resolved.

@FriederikeHanssen FriederikeHanssen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good idea, but maybe a few people could add there opinions here

@mirpedrol mirpedrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a good solution 👍

@codecov

codecov Bot commented Jan 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2163 (67c8aa9) into dev (681ccf3) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2163      +/-   ##
==========================================
+ Coverage   71.44%   71.49%   +0.04%     
==========================================
  Files          77       77              
  Lines        8378     8378              
==========================================
+ Hits         5986     5990       +4     
+ Misses       2392     2388       -4     
Impacted Files Coverage Δ
nf_core/utils.py 82.38% <0.00%> (+0.18%) ⬆️
nf_core/modules/test_yml_builder.py 52.00% <0.00%> (+1.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ewels ewels left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfy133 jfy133 merged commit 546548a into dev Jan 20, 2023
@jfy133 jfy133 deleted the auto-cleanup-fulltest branch January 20, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants