You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We install the subworkflow to an old version, as the module in this subworkflow has the old name when it tries to install it from nf-core/modules it's not found.
I think the module should also be installed to the old version but I'm not sure about how file renaming works when we clone the modules repo.
It might actually be a bug on tools 🤔
We need the outdated subworkflow for this test as we check a change of module, this one is the only subworkflow that I could find with this change :(
Will try to find where are things breaking.
I think the problem is that we check if the module is available before installing it, and to do this we get the list of available modules from the last nf-core/modules repo version.
If I'm not wrong, this only affects name changes like this one when move from TOOL to TOOL/SUBTOOL, and only when modules are automatically installed from a subworkflow, not when installing them by command line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a typo that I introduced with #2175
The
descriptionfield ofmeta.ymlwhen the flag was not provided was attached to the previous line (without a new line).We can sneak this into the next PR as it's a tiny change, leaving it here as a reminder.
PR checklist
CHANGELOG.mdis updateddocsis updated