Fix tests after modifying the GitLab org-path to nf-core-test#2239
Conversation
mashehu
left a comment
There was a problem hiding this comment.
Do I understand correctly, that we don't need the remove-function anymore, because can handle the conflicts now gracefully?
|
This remove function was added to avoid errors with the GitLab repo, as the org_path there was also nf-core. Now I changed the org_path to nf-core-test as @anoronh4 suggested, so we don't have to remove the modules :) |
Codecov Report
@@ Coverage Diff @@
## dev #2239 +/- ##
==========================================
+ Coverage 73.05% 73.12% +0.07%
==========================================
Files 77 77
Lines 8342 8342
==========================================
+ Hits 6094 6100 +6
+ Misses 2248 2242 -6
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
anoronh4
left a comment
There was a problem hiding this comment.
This code chunk is causing a few tests to fail. Because we now have two org_paths certain discordant states are being caught that maybe shouldn't have passed before. i think we can fix this by simply replacing:
for dir_name in missing_installation[repo][component_type]:
if component in missing_installation[repo][component_type][dir_name]:
with:
if install_dir in missing_installation[repo][component_type]:
if component in missing_installation[repo][component_type][install_dir]:
that way we are matching installed components with the corresponding org_paths/repos instead of crossing wires.
|
Thanks for the suggestion @anoronh4 :) |
|
@mirpedrol interesting, i was able to reproduce the CI errors locally, but only after i cleared a local cache of the modules-test repo ~/.config/nfcore/nf-core/modules-test/ (seems like it didn't like my previously loaded git index). I think we are good to go now! |
Follow up from #2228
PR checklist
CHANGELOG.mdis updateddocsis updated