Skip to content

add apptainer.registry#2352

Merged
maxulysse merged 3 commits into
devfrom
apptainer
Jun 30, 2023
Merged

add apptainer.registry#2352
maxulysse merged 3 commits into
devfrom
apptainer

Conversation

@maxulysse

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the speedy PR!

@ewels ewels left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog

@mirpedrol mirpedrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@maxulysse

Copy link
Copy Markdown
Member Author

And we have a CHANGELOG even

Comment thread CHANGELOG.md Outdated
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@maxulysse maxulysse merged commit fb4801b into dev Jun 30, 2023
@maxulysse maxulysse deleted the apptainer branch June 30, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants