Remove fixed Ubuntu 20.04 testing workflow#2397
Conversation
This PR is against the
|
Codecov Report
@@ Coverage Diff @@
## dev #2397 +/- ##
==========================================
+ Coverage 71.09% 71.14% +0.05%
==========================================
Files 87 87
Lines 9409 9409
==========================================
+ Hits 6689 6694 +5
+ Misses 2720 2715 -5 |
edmundmiller
left a comment
There was a problem hiding this comment.
Looks good to me, I didn't know you could do that!
| env: | ||
| GITHUB_TOKEN: ${{ github.token }} |
There was a problem hiding this comment.
| env: | |
| GITHUB_TOKEN: ${{ github.token }} |
What's the purpose of adding this? Just wondering for our future selves! 😄
There was a problem hiding this comment.
I was hitting API limits, I hoped it might authenticate by default and it seemed to help! Looking at the code I think it's just coincidence but maybe it worked.
I bet if I remove it it will break.
| pip install -e . | ||
|
|
||
| - name: Downgrade git to the Ubuntu official repository's version | ||
| if: ${{ matrix.runner == 'ubuntu-20.04' && matrix.python-version == '3.8' }} |
There was a problem hiding this comment.
| if: ${{ matrix.runner == 'ubuntu-20.04' && matrix.python-version == '3.8' }} | |
| if: ${{ matrix.runner == 'ubuntu-20.04' && matrix.python-version == '3.8' }} | |
| env: | |
| GITHUB_TOKEN: ${{ github.token }} |
Is this the scope it's needed in?
There was a problem hiding this comment.
Yep, it reflects the original test which used a couple of older versions of software together to mimic a scenario. If you look at the tests it seems to be working correctly.
Removes the pytest fixed version on Ubuntu:20.04 and Python 3.8 and adds it to matrix variables.
Original merge that added it: #2043
Using fewer workflows it better for enforcing code coverage etc. and managing testing throughput.
PR checklist
CHANGELOG.mdis updateddocsis updated