Add lint test to check existence of test profile#2478
Merged
Conversation
2efda30 to
0cf3fbd
Compare
0cf3fbd to
6c0325f
Compare
Contributor
Author
|
The test is now parsing nextflow.config to verify the existence of the |
Codecov Report
@@ Coverage Diff @@
## dev #2478 +/- ##
==========================================
- Coverage 70.71% 70.63% -0.08%
==========================================
Files 87 87
Lines 9424 9461 +37
==========================================
+ Hits 6664 6683 +19
- Misses 2760 2778 +18
|
Contributor
|
we added a new type checker for python code, which unfortunately is still a bit too aggressive. you can ignore that specific test for now. |
mashehu
approved these changes
Oct 17, 2023
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
CHANGELOG.mdis updateddocsis updatedThis is the first part of #1837.
See below comment: The following is no longer true (no way to "strike through" in github?):
It is not an ideal implementation, because it has to call
nextflow, and only gets indirect indication of the failure due to the exit code. If there's a better way to reliably parse the config with python, I will use that instead- I hope someone can offer guidance on that if possible.This is a draft PR, not ready for merge.