Skip to content

Ignore ignored config variables#2507

Merged
rernst merged 5 commits into
nf-core:devfrom
rernst:dev
Dec 1, 2023
Merged

Ignore ignored config variables#2507
rernst merged 5 commits into
nf-core:devfrom
rernst:dev

Conversation

@rernst

@rernst rernst commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

Skip timeline.enabled, report.enabled, trace.enabled and dag.enabled if they are configured as ignorable. Currently nf-core lint does not take this setting into account for these variables. I don't think any test or documentation changes are required.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@rernst rernst marked this pull request as ready for review November 9, 2023 12:27

@mirpedrol mirpedrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread CHANGELOG.md Outdated
rernst and others added 3 commits November 13, 2023 20:05
@rernst rernst merged commit a91d411 into nf-core:dev Dec 1, 2023
@rernst rernst deleted the dev branch December 1, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants