Skip to content

Linting: fix bug when linting subworkflows from pipeline lint [skip changelog]#2689

Merged
mirpedrol merged 1 commit into
nf-core:devfrom
mirpedrol:subworkflow-lint
Jan 29, 2024
Merged

Linting: fix bug when linting subworkflows from pipeline lint [skip changelog]#2689
mirpedrol merged 1 commit into
nf-core:devfrom
mirpedrol:subworkflow-lint

Conversation

@mirpedrol

Copy link
Copy Markdown
Member

Fix a bug introduced with #2677

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@mashehu

mashehu commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

should we test for this or you think it was an outlier?

@mirpedrol

Copy link
Copy Markdown
Member Author

We are not running the linting of a pipeline, that's why me missed this, as linting subworkflows alone worked.

tools/tests/test_lint.py

Lines 57 to 58 in 50d56f6

We don't really check any of this code as it's just a series of function calls
and we're testing each of those individually. This is mostly to check for syntax errors."""

Do we want to actually run it?

@mashehu

mashehu commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

I see, maybe fine for now then

@mirpedrol mirpedrol merged commit 6805ee1 into nf-core:dev Jan 29, 2024
@mirpedrol mirpedrol deleted the subworkflow-lint branch January 29, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants