Remove old references to CUSTOMDUMPSOFTWAREVERSIONS#2897
Conversation
ewels
left a comment
There was a problem hiding this comment.
Can we also add a lint test for this please?
|
@mirpedrol @mashehu help! |
|
haha, you ran into the same nf-core tools trap as @Joon-Klaps did 🙂 |
|
but I can have a look after I found a fix for #2890 |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
|
|
||
| # Return a failed status if we can't find the file | ||
| if not fn.is_file(): | ||
| return {"failed": [f"`${file_path}` not found"]} |
There was a problem hiding this comment.
Would it be better to make this a warning? Some pipelines (like sarek) don't use these config files.
There was a problem hiding this comment.
better to have them ignore it, imo
| f"`{file_path}` contains `withName:{section}`, but the corresponding process is not present in any of the following workflow files: `{nf_files}`." | ||
| ) | ||
| else: | ||
| passed.append(f"both `{file_path}` and `{[str(f) for f in nf_files]} contain `{section}`.") |
There was a problem hiding this comment.
Not sure if the list of .nf files will be too long. Maybe a general message is enough
| passed.append(f"both `{file_path}` and `{[str(f) for f in nf_files]} contain `{section}`.") | |
| passed.append(f"`{section}` found in `{file_path}` and Nextflow scripts.") |
There was a problem hiding this comment.
okay, but I'll add a debuggin log, so it is a bit easier to debug
…-core/tools into remove-old-customdumpsoftwareversions
Removes left over CUSTOMDUMPSOFTWAREVERSIONS references from template that has been since replaced with a dedicated special function
PR checklist
CHANGELOG.mdis updateddocsis updated