Fix incorrect assertions for called_with on mocks#2891
Merged
Conversation
…ing mocks before 3.12. Broken in 3.12.
mashehu
approved these changes
Mar 20, 2024
Contributor
Author
|
We need to resolve the issue with the I cannot for the life of me figure out what the correct way to patch the method call of the pipeline Schema object is. I think perhaps there is an issue with the fact the class is imported inside the cli function? |
4 tasks
awgymer
commented
Mar 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
mirpedrol
reviewed
Mar 26, 2024
Contributor
Author
|
So is this good to merge now? It will make a lot of other PRs stop failing! |
Contributor
|
I guess so😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2890
fix: assertions for called_with/called_once_with were silently returning mocks before 3.12. Broken in 3.12.
PR checklist
CHANGELOG.mdis updateddocsis updated