Skip to content

Restructure pipeline tests and move pipeline linting into subfolder#3070

Merged
mashehu merged 92 commits into
nf-core:devfrom
mashehu:move-pipeline-linting
Aug 12, 2024
Merged

Restructure pipeline tests and move pipeline linting into subfolder#3070
mashehu merged 92 commits into
nf-core:devfrom
mashehu:move-pipeline-linting

Conversation

@mashehu

@mashehu mashehu commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

Trying out if I can clean up a bit the pytest setup to make them more similar to the component ones (and probably vice versa).

@mashehu mashehu added the WIP Work in progress label Jul 16, 2024
@mashehu mashehu changed the title Rrestructure pipeline tests and move pipeline linting into subfolder Restructure pipeline tests and move pipeline linting into subfolder Jul 17, 2024
Comment thread nf_core/utils.py Outdated
Comment thread nf_core/utils.py
Comment thread pytest.ini
Comment thread requirements.txt
Comment thread tests/pipelines/lint/files_exist.py Outdated
Comment thread nf_core/pipelines/lint/__init__.py

@mirpedrol mirpedrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Still found some use of dir, like here, if you want to remove all of them :)

elif component in self.update_config.get(self.modules_repo.remote_url, {}).get(install_dir, {}):
# If the component to update is in .nf-core.yml config file
config_entry = self.update_config[self.modules_repo.remote_url][install_dir].get(component)
if self.update_config is not None:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous UserWarning is still missing

…ting

# Conflicts:
#	.pre-commit-config.yaml
#	CHANGELOG.md
#	nf_core/__main__.py
#	nf_core/commands_modules.py
#	nf_core/commands_subworkflows.py
#	nf_core/pipelines/create/create.py
@mashehu mashehu merged commit ef946e9 into nf-core:dev Aug 12, 2024
@mashehu mashehu deleted the move-pipeline-linting branch August 12, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants