Skip to content

TEMPLATE: Fix version comment action#3212

Merged
mirpedrol merged 6 commits into
nf-core:devfrom
mashehu:fix-template-version-comment-action
Oct 11, 2024
Merged

TEMPLATE: Fix version comment action#3212
mirpedrol merged 6 commits into
nf-core:devfrom
mashehu:fix-template-version-comment-action

Conversation

@mashehu

@mashehu mashehu commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@mashehu mashehu requested a review from mirpedrol October 9, 2024 13:54

@jfy133 jfy133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came across this issue in 3.0.1 😬

@maxulysse maxulysse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still not working 😭
cf nf-core/sarek#1681

@mirpedrol

Copy link
Copy Markdown
Member

Looks like there is an error with the action to read the yaml file pietrobolcato/action-read-yaml#14 should we try the fork mentioned in this issue?

@maxulysse

Copy link
Copy Markdown
Member

As far as I can tell all PRs once a template sync has been merged ran into this error

@mirpedrol mirpedrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working now 🙂 LGTM!

@mashehu mashehu requested a review from maxulysse October 10, 2024 13:42
@maxulysse

Copy link
Copy Markdown
Member

CHANGELOG?

@mirpedrol mirpedrol force-pushed the fix-template-version-comment-action branch from 1b9d8e9 to 1b429cb Compare October 11, 2024 07:08
@mirpedrol mirpedrol merged commit 5d368d7 into nf-core:dev Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants