Modules: add a panel around diff previews when updating#3246
Conversation
|
Do you have a screnshot as to what it looks like? |
jfy133
left a comment
There was a problem hiding this comment.
Yes, but it would also be nice to have a marker between each group of files too, e.g. set of files per module.
My reasoning is I need to make sure e.g. I look at the combination of a main.nf and meta to make sure I understand what channel modifications I have to make in the pipeline
|
okay, a bit more difficult, but I will give it a try |
Can just be a straight line across the whole width of screen printed before the question of 'updated X/y/z module'? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
|
better? |
|
alternative 2 |
|
Yes I think that will do for now (would need to try to test in the wild a few times ). The blue border is nice but I find it's a hit harder to read the name of the module But no strong feeling on the colour |
|
how about this then |
fixes #3239