Skip to content

handle new schema structure in nf-core pipelines create-params-file#3276

Merged
mashehu merged 4 commits into
nf-core:devfrom
mashehu:fix-create-params
Nov 12, 2024
Merged

handle new schema structure in nf-core pipelines create-params-file#3276
mashehu merged 4 commits into
nf-core:devfrom
mashehu:fix-create-params

Conversation

@mashehu

@mashehu mashehu commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@mashehu mashehu requested a review from mirpedrol November 11, 2024 15:45
@codecov

codecov Bot commented Nov 11, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.84%. Comparing base (27659c5) to head (e57a096).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/params_file.py 72.00% 7 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mashehu mashehu merged commit 24e2dc2 into nf-core:dev Nov 12, 2024
@mashehu mashehu deleted the fix-create-params branch November 12, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants